NUVOTON: Fix for target.boot-stack-size config in linker script #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"target.boot-stack-size" can expand to MBED_CONF_TARGET_BOOT_STACK_SIZE or legacy MBED_BOOT_STACK_SIZE. Though MBED_BOOT_STACK_SIZE is unsupported in Mbed CE, make its preprocess consistent in linker scripts by prioritizing MBED_CONF_TARGET_BOOT_STACK_SIZE, then MBED_BOOT_STACK_SIZE for being compatible.
ccli8
force-pushed
the
nvt_fix_boot_stack_config
branch
from
3c39dfe to
713c89e
Compare
multiplemonomials
approved these changes
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This PR fixes for
target.boot-stack-sizeconfig preprocess in linker scripts for Nuvoton targets.target.boot-stack-sizecan expand toMBED_CONF_TARGET_BOOT_STACK_SIZEor legacyMBED_BOOT_STACK_SIZE. ThoughMBED_BOOT_STACK_SIZEis unsupported in Mbed CE, make its preprocess consistent in linker scripts by prioritizingMBED_CONF_TARGET_BOOT_STACK_SIZE, thenMBED_BOOT_STACK_SIZEfor being compatible.Pull request type